Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations (#44) #130

Merged

Conversation

lruozzi9
Copy link
Member

Fixes #44

Changes proposed in this pull request:

  • Remove all service and argument deprecations

@webgriffe/wg-devs what do you think about this PR :shipit:?

@lruozzi9 lruozzi9 added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 11, 2022
@lruozzi9 lruozzi9 added this to the v2.0.0 milestone Apr 11, 2022
@lruozzi9 lruozzi9 self-assigned this Apr 11, 2022
@lruozzi9 lruozzi9 force-pushed the 44-remove-duplicated-resources-definition-and-aliases-for-bc branch from f67b6c3 to 7ea28b0 Compare April 11, 2022 10:10
@lruozzi9 lruozzi9 changed the title Remove deprecations Remove deprecations (#44) Apr 11, 2022
@lruozzi9 lruozzi9 marked this pull request as ready for review April 11, 2022 10:15
CHANGELOG-2.0.md Outdated
@@ -1,30 +1,16 @@
# UPGRADE FROM `v1.13.3` TO `v2.0.0`
# CHANGELOG FOR `2.0.X`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's worth to maintain a changelog for 2.x...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Member

@LucaGallinari LucaGallinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@lruozzi9 lruozzi9 force-pushed the 44-remove-duplicated-resources-definition-and-aliases-for-bc branch from 7ea28b0 to 3c36d63 Compare June 6, 2022 09:19
Copy link
Member

@mmenozzi mmenozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@lruozzi9 lruozzi9 merged commit cd11b3b into master Jun 7, 2022
@lruozzi9 lruozzi9 deleted the 44-remove-duplicated-resources-definition-and-aliases-for-bc branch June 7, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicated resources definition and aliases for BC
3 participants